[Webkit-unassigned] [Bug 72996] [chromium] Add page-scale animation support to Impl thread

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72996





--- Comment #10 from Adrienne Walker <enne at google.com>  2011-11-23 16:15:13 PST ---
(From update of attachment 116427)
View in context: https://bugs.webkit.org/attachment.cgi?id=116427&action=review

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:91
> +    IntSize scrollTotal = m_scrollLayerImpl->scrollPosition() + m_scrollLayerImpl->scrollDelta() - IntPoint();

nit: use toSize() here instead of "- IntPoint()".

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:248
> +    IntSize scrollTotal = m_scrollLayerImpl->scrollPosition() + m_scrollLayerImpl->scrollDelta() - IntPoint();

nit: same as other IntPoint() comment.

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:250
> +    m_pageScaleAnimation = adoptPtr(new CCPageScaleAnimation(scrollTotal, m_pageScale, m_viewportSize, currentTimeMs()));

What happens if startPageScaleAnimation is called again in the middle of a page scale animation? Should we early out or maybe call zoomElsewhere?

> Source/WebCore/platform/graphics/chromium/cc/CCPageScaleAnimation.cpp:106
> +void CCPageScaleAnimation::zoomElsewhere(const IntSize& finalScroll, float finalPageScale, double duration, double time)

Where does this get used?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.