[Webkit-unassigned] [Bug 72996] [chromium] Add page-scale animation support to Impl thread

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 23 14:48:42 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=72996


Alexandre Elias <aelias at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |enne at google.com




--- Comment #8 from Alexandre Elias <aelias at chromium.org>  2011-11-23 14:48:41 PST ---
There are two completely different kinds of page scale events.  This one is for double-tap gestures, where the user taps on a page element and then a zoom animation occurs bringing it forward.  The other one is still in Clank-branch only, and represent pinch gestures


Double-tap input events are unlike the other events in that they need to be augmented by information about the document structure.  If a user double-taps on an image for instance, we need to get its size to know the target page scale to animate to.  The input event is passed first to the WebKit thread to gather this data.  Since the ViewMsg channel is from browser -> compositor thread, I didn't know how to use the normal input handler from there.

Now I figured out I can post a ViewMsg_HandleInputEvent task directly to InputEventHandler::OnMessageReceived from RenderViewImpl.  However, now I'm concerned about this:

  // TODO(darin): Change RenderWidgetHost to always require an ACK before
  // sending the next input event.  This way we can nuke this queue.

I'm not sending from RenderWidgetHost so if the queue goes away, this approach would stop working.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list