[Webkit-unassigned] [Bug 72952] [GTK] Add WebKitDownloadClient to WebKit2 GTK+ API

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 23 09:24:48 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=72952


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mrobinson at webkit.org




--- Comment #7 from Martin Robinson <mrobinson at webkit.org>  2011-11-23 09:24:48 PST ---
(In reply to comment #6)
> My proposal is something like: 
> 
> WebKitDownloadClient::started -> WebKitWebContext::download-started
> WebKitDownloadClient::received-response -> WebKitDownload:response
> WebKitDownloadClient::received-data -> WebKitDownload:bytes-received (or current-size, I'm not sure about the name)
> WebKitDownloadClient::finished -> WebKitDownload::finished
> WebKitDownloadClient::failed ->  WebKitDownload::failed
> WebKitDownloadClient::decide-destination -> WebKitDownload::decide-destination
> WebKitDownloadClient::created-destination -> WebKitDownload::created-destination
> And make destination a property of WEbKitDownload so that it can be monitored.

I think this is a great proposal. The only thing I would change is WebKitDownloadClient::received-response  into WebKitDownloadClient::response-received.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list