[Webkit-unassigned] [Bug 66477] [GTK] Html5 Notification, testing facilities

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66477


Philippe Normand <pnormand at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #114466|review?                     |review-
               Flag|                            |




--- Comment #14 from Philippe Normand <pnormand at igalia.com>  2011-11-23 09:24:47 PST ---
(From update of attachment 114466)
View in context: https://bugs.webkit.org/attachment.cgi?id=114466&action=review

Thanks! This looks quite good, I found some little nits to fix though :)

> Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:1125
> +    return g_strdup_printf("%s://%s",
> +                           webkit_security_origin_get_protocol(origin),
> +                           webkit_security_origin_get_host(origin));

This can fit in one or two lines.

> Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:1176
> +      JSStringRef jsOrigin = JSStringCreateWithUTF8CString(originStr.get());

Weird indentation :)

> Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:1197
> +    bool permited = gLayoutTestController->checkDesktopNotificationPermission(jsOrigin);

s/permited/allowed ?

> Tools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:1037
> +    if (!match)

notificationTitle is leaked in this case.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.