[Webkit-unassigned] [Bug 72353] [SOUP][WK2] Implement the functions to manager cookies in CookieJar for WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72353


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #115099|review?                     |review-
               Flag|                            |




--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2011-11-23 07:47:28 PST ---
(From update of attachment 115099)
View in context: https://bugs.webkit.org/attachment.cgi?id=115099&action=review

Looks fine to me, but I have some style nits.

> Source/WebCore/platform/network/soup/CookieJarSoup.cpp:131
> +    GSList* cookies;
> +    GSList* item;
> +    SoupCookie* soupCookie;
> +    char* domain;
> +

In WebKit we typically declare variables when they are first used and in the scope they are used.

> Source/WebCore/platform/network/soup/CookieJarSoup.cpp:150
> +    GSList* cookies;
> +    GSList* item;
> +    SoupCookie* soupCookie;
> +    char* domain;

Ditto.

> Source/WebCore/platform/network/soup/CookieJarSoup.cpp:168
> +    GSList* cookies;
> +    GSList* item;

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.