[Webkit-unassigned] [Bug 71050] [Microdata] Support for properties attribute.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71050


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #115575|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #10 from Adam Barth <abarth at webkit.org>  2011-11-23 01:03:32 PST ---
(From update of attachment 115575)
View in context: https://bugs.webkit.org/attachment.cgi?id=115575&action=review

Below are a few minor nits.  It would be nice to include more tests, but it's always nicer to include more tests.  :)

> Source/WebCore/dom/Node.h:86
> +class DOMSettableTokenList;

This shouldn't be guarded by this macro because it's defined outside of ENABLE(MICRODATA)

> Source/WebCore/dom/NodeRareData.h:29
> +#include "DOMSettableTokenList.h"

Same here.

> Source/WebCore/html/CollectionType.h:58
> +        ItemProperties, // Microdata item properties in the document

Bad indent

> Source/WebCore/html/HTMLPropertiesCollection.cpp:33
> +#if ENABLE(MICRODATA)

We usually have a blank line below this line.

> Source/WebCore/html/HTMLPropertiesCollection.cpp:69
> +    Vector<Node*> memory, pending;

We usually don't use compound declarations.

> Source/WebCore/html/HTMLPropertiesCollection.h:38
> +namespace WebCore {

We usually have a blank line below this line.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.