[Webkit-unassigned] [Bug 72996] [chromium] Add page-scale animation support to Impl thread

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72996


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #116303|review?                     |review-
               Flag|                            |




--- Comment #3 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2011-11-22 20:34:52 PST ---
(From update of attachment 116303)
View in context: https://bugs.webkit.org/attachment.cgi?id=116303&action=review

> Source/WebKit/chromium/public/WebCompositor.h:47
> +    virtual void handlePageScaleAnimationEvent(const WebPageScaleAnimationEvent&) = 0;

since WebPageScaleAnimationEvent inherits from WebInputEvent, you don't need this method.  just use handleInputEvent.

> Source/WebKit/chromium/public/WebInputEvent.h:371
> +class WebPageScaleAnimationEvent : public WebInputEvent {

this seems like it could/should be represented as a type of gesture event.  or maybe
we should derive from WebGestureEvent and call this a WebPageScaleGestureEvent?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.