[Webkit-unassigned] [Bug 72878] Strength reduction for Mul and Mod operations for known constants in DFG

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72878


Filip Pizlo <fpizlo at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #116177|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #7 from Filip Pizlo <fpizlo at apple.com>  2011-11-22 19:13:14 PST ---
(From update of attachment 116177)
View in context: https://bugs.webkit.org/attachment.cgi?id=116177&action=review

Looks great!  Two comments:

1) Can you check that the indentation is 4 spaces, no tabs, in the one place I pointed out?

2) Since there is no clear win on major benchmarks, can you construct a micro benchmark that demonstrates the win?  It can be arbitrarily simple.  I think that this patch is a good idea, and it's the right direction, but we just need to make sure that it does what we think it does.

I'm marking it r+ and cq- so that you can check the indentation.

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:1602
> +        if (x) {
> +          num = x;
> +          log += shift;
> +        }

Is the indentation right here?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.