[Webkit-unassigned] [Bug 70634] Mark GraphicsLayers as opaque when possible

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 22 12:09:16 PST 2011


--- Comment #60 from Dana Jansens <danakj at chromium.org>  2011-11-22 12:09:15 PST ---
(In reply to comment #59)
> With composited <img> tags, the backing uses GraphicsLayer::setContentsToImage() rather than the general code-path.  Opaque-ness needs to be tested in the GraphicsLayer subclass.
> In order to test opaque RenderImage objects, we need the image to be a child of a composited object.  This patch doesn't consider child RenderObjects so we can't test them just yet.  I've created tests for them in the next-step edition.

Sorry for the noise. I see that RenderImage objects are used for composited <img> tags when they have a border/padding/etc.  So adding tests in here for images with borders/padding/etc.

As noted by the bots, this will break some existing LayoutTests due to them now have opaque stuff.  I've never dealt with this before and would appreciate some guidance on this process. Should I be resetting results in those tests in this CL? Should I make a follow up CL with the reset?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list