[Webkit-unassigned] [Bug 57008] prepare-ChangeLog doesn't find names of modified classes/methods in Python source files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57008





--- Comment #5 from Adam Roben (:aroben) <aroben at apple.com>  2011-11-22 08:44:45 PST ---
(From update of attachment 116227)
View in context: https://bugs.webkit.org/attachment.cgi?id=116227&action=review

>> Tools/ChangeLog:12
>> +        or that use python as their interpreter. Modified the code that extracts the interpreter to
> 
> Nit: python => Python

Here I was referring to "python" the utility, not Python the language.

>> Tools/ChangeLog:13
>> +        ignore an leading "/usr/bin/env " in the interpreter line, as is common for our Python
> 
> Nit: an => a

Fixed.

>> Tools/Scripts/prepare-ChangeLog:1274
>> +            for (; $i < scalar(@scopeStack); ++$i) {
> 
> Nit: scalar(@scopeStack) => @scopeStack
> 
> It's unnecessary to call scalar() in this context.

Removed.

>> Tools/Scripts/prepare-ChangeLog:1282
>> +            for ($i = 0; $i < scalar(@poppedScopes); ++$i) {
> 
> Nit: scalar(@poppedScopes) => @poppedScopes

Removed.

>> Tools/Scripts/prepare-ChangeLog:1283
>> +                my $lineAfterEnd = $i + 1 == scalar(@poppedScopes) ? $. : $poppedScopes[$i + 1]->{line};
> 
> Ditto.

Removed.

>> Tools/Scripts/prepare-ChangeLog:1286
>> +            scalar(@scopeStack) or warn "Popped off last scope at $fileName:$.\n";
> 
> Ditto.

Removed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.