[Webkit-unassigned] [Bug 57008] prepare-ChangeLog doesn't find names of modified classes/methods in Python source files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57008


Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #116227|review?                     |review+
               Flag|                            |




--- Comment #4 from Daniel Bates <dbates at webkit.org>  2011-11-22 08:36:10 PST ---
(From update of attachment 116227)
View in context: https://bugs.webkit.org/attachment.cgi?id=116227&action=review

This looks good to me. I have some minor nits.

> Tools/ChangeLog:12
> +        or that use python as their interpreter. Modified the code that extracts the interpreter to

Nit: python => Python

> Tools/ChangeLog:13
> +        ignore an leading "/usr/bin/env " in the interpreter line, as is common for our Python

Nit: an => a

> Tools/Scripts/prepare-ChangeLog:1274
> +            for (; $i < scalar(@scopeStack); ++$i) {

Nit: scalar(@scopeStack) => @scopeStack

It's unnecessary to call scalar() in this context.

> Tools/Scripts/prepare-ChangeLog:1282
> +            for ($i = 0; $i < scalar(@poppedScopes); ++$i) {

Nit: scalar(@poppedScopes) => @poppedScopes

> Tools/Scripts/prepare-ChangeLog:1283
> +                my $lineAfterEnd = $i + 1 == scalar(@poppedScopes) ? $. : $poppedScopes[$i + 1]->{line};

Ditto.

> Tools/Scripts/prepare-ChangeLog:1286
> +            scalar(@scopeStack) or warn "Popped off last scope at $fileName:$.\n";

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.