[Webkit-unassigned] [Bug 72889] Add interface for runtime option settings

Tue Nov 22 01:51:35 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=72889

--- Comment #13 from Andy Wingo <wingo at igalia.com>  2011-11-22 01:51:35 PST ---
(In reply to comment #11)
> I saw that Options class and assumed that you wanted to pass different instances of it around.  Now I see that it's meant to be static.

Yes, it's an abuse of classes as an organizational device.

Like I said, my C++ instincts are terrible :), but I thought that it could be a good idea to avoid accidental modification of the options / heuristics, and so hide them behind a static method. The method should inline, just in case that's important.

> Anything you do in Options should be done in such a way that it can be tuned from a full browser.  The environment variables are a cheap way to accomplish this.  Do you know how you'd interface this to WebCore/WebKit so that the options can be modified even for a browser?

We could provide the same interface, or we could provide API, or provide a little parser for e.g. JSC_HEURISTICS='likely-to-take-slow-case-threshold=4,maximum-optimization-delay=35,..'

I like your suggestion of just renaming Heuristics to Options and refactoring from there.  I'll post a patch to do that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.