[Webkit-unassigned] [Bug 71991] Spellcheck should be able to run asynchronously

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71991


MORITA Hajime <morrita at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #116164|review?                     |review-
               Flag|                            |




--- Comment #4 from MORITA Hajime <morrita at google.com>  2011-11-21 20:42:18 PST ---
(From update of attachment 116164)
View in context: https://bugs.webkit.org/attachment.cgi?id=116164&action=review

Is it possible to add a test that modify the checking range content during the spellcheck request is in flight?

> Source/WebCore/ChangeLog:7
> +

Could you add some detailed explanation here?
The bug summary  isn't enough.

> Source/WebCore/editing/Editor.cpp:1882
> +            if (asynchronous)

It looks async check and m_spellChecker invocation can be a part of markAllMisspellingsAndBadGrammarInRanges().

> Source/WebCore/editing/SpellChecker.cpp:134
> +    if (shouldMarkGrammar)

Maybe body of this if() statement should be a part of the if clause above.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.