[Webkit-unassigned] [Bug 71791] [EFL] Add implementation considering ewk_tiled_backing_store's visible status.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71791





--- Comment #17 from KwangHyuk <hyuki.kim at samsung.com>  2011-11-21 17:54:16 PST ---
(In reply to comment #16)
> (From update of attachment 116032 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=116032&action=review
> 
> > Source/WebKit/efl/ChangeLog:8
> > +        In order to prevent unexpected rendering and pre-rendering while backing store is hidden,
> 
> "Unexpected" in what sense? Is anything rendered wrong?
> 
It's not about wrong and right thing.
As webkit1 is just based on single thread, any rendering on background can hurt user interaction for the visible view in front.
As a result, I better change title one more time to avoid misunderstood of this patch.

> > Source/WebKit/efl/ChangeLog:9
> > +        its visibility is checked and pre-rendering is handled whenever backing store is shown or hidden.
> 
> Is there a risk of some events being lost with this change?
> 
According to the patch, pre-render request won't be flushed.


> > Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp:74
> > +        bool visible:1;
> 
> Isn't it possible to use evas_object_visible_get/set and drop this flag?
Good point,
In fact, I have thought that flag check cost is lighter than api call.
But, I will reconsider this one more time.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.