[Webkit-unassigned] [Bug 69870] [Chromium] Empty API for web intents

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69870


Greg Billock <gbillock at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #115877|1                           |0
        is obsolete|                            |




--- Comment #18 from Greg Billock <gbillock at google.com>  2011-11-21 14:32:20 PST ---
(From update of attachment 115877)
View in context: https://bugs.webkit.org/attachment.cgi?id=115877&action=review

>> Source/WebKit/chromium/public/WebFrame.h:554
>> +    virtual void handleIntentFailure(const WebString&, int intentId) = 0;
> 
> nit: I think it would be better to list the intentIdentifier first since that
> identifies the intent.  the WebString is just payload, so it seems secondary.
> 
> nit: spell out intentIdentifier since this corresponds to WebIntent::identifier().
> (it helps to keep these as similar as possible to strengthen their relationship.)

Done.

>> Source/WebKit/chromium/public/WebFrameClient.h:392
>> +    // the WebFrame starting the activity. The |intentId| is an arbitrary
> 
> nit: fix this comment.  it refers to "intentId" which doesn't exist as a direct parameter to this method.

Done.

>> Source/WebKit/chromium/public/WebIntentServiceInfo.h:40
>> +// The |url| is the location of the handler page registered by the service.
> 
> nit: Move these comments to be above their respective method groups.  e.g.:
> 
>   // The location of the handler page registered by the service.
>   WEBKIT_EXPORT WebURL url() const;
>   WEBKIT_EXPORT void setURL(const WebURL&);
> 
> ^^^ This way you don't have to repeat the name of the property.

Done.

>> Source/WebKit/chromium/public/WebIntentServiceInfo.h:53
>> +    WEBKIT_EXPORT WebString url() const;
> 
> I think you meant url() to return WebURL?

This is representing the "href" attribute of the intent tag. Will we get sufficient error handling by returning WebURL?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.