[Webkit-unassigned] [Bug 69870] [Chromium] Empty API for web intents

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69870


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #115877|review?                     |review-
               Flag|                            |




--- Comment #15 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2011-11-21 12:57:03 PST ---
(From update of attachment 115877)
View in context: https://bugs.webkit.org/attachment.cgi?id=115877&action=review

> Source/WebKit/chromium/public/WebFrame.h:554
> +    virtual void handleIntentFailure(const WebString&, int intentId) = 0;

nit: I think it would be better to list the intentIdentifier first since that
identifies the intent.  the WebString is just payload, so it seems secondary.

nit: spell out intentIdentifier since this corresponds to WebIntent::identifier().
(it helps to keep these as similar as possible to strengthen their relationship.)

> Source/WebKit/chromium/public/WebFrameClient.h:392
> +    // the WebFrame starting the activity. The |intentId| is an arbitrary

nit: fix this comment.  it refers to "intentId" which doesn't exist as a direct parameter to this method.

> Source/WebKit/chromium/public/WebIntentServiceInfo.h:40
> +// The |url| is the location of the handler page registered by the service.

nit: Move these comments to be above their respective method groups.  e.g.:

  // The location of the handler page registered by the service.
  WEBKIT_EXPORT WebURL url() const;
  WEBKIT_EXPORT void setURL(const WebURL&);

^^^ This way you don't have to repeat the name of the property.

> Source/WebKit/chromium/public/WebIntentServiceInfo.h:53
> +    WEBKIT_EXPORT WebString url() const;

I think you meant url() to return WebURL?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.