[Webkit-unassigned] [Bug 70484] [WK2] add flag to only check pixel results if png files exist

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70484


Dirk Pranke <dpranke at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #116019|review?                     |review-
               Flag|                            |




--- Comment #18 from Dirk Pranke <dpranke at chromium.org>  2011-11-21 12:39:23 PST ---
(From update of attachment 116019)
View in context: https://bugs.webkit.org/attachment.cgi?id=116019&action=review

> Tools/Scripts/webkitpy/layout_tests/controllers/worker.py:113
> +                if skip_pixel_test_if_no_baseline.skip_pixel_test(self._port, test_input.test_name):

Can't you just replace this with:

test_input.should_run_pixel_test = (port.expected_image(test_name) == None)

and delete skip_pixel_test_if_no_baseline.py ?

Also, I still don't understand why you are limiting this flag to WebKitTestRunner. It doesn't seem like anything will break if you run this on other ports?

> Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py:159
> +            if skip_pixel_test_if_no_baseline.skip_pixel_test(port, test_name):

I suggest you just inline the function here as well.

> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:69
> +            return -1

As I suggested above, I don't think this check is necessary.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.