[Webkit-unassigned] [Bug 72889] Add interface for runtime option settings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72889





--- Comment #7 from Andy Wingo <wingo at igalia.com>  2011-11-21 10:15:51 PST ---
Attached patch introduces some cruft so that accessors are always there.

To use the one flag that currently exists as an example, --dump-bytecode is only available in debug mode.  This has always been the case, under its old -d name, but now it is only present in jsc --help in debug mode.

Transcript, in debug mode:

$ ./WebKitBuild/Debug/Programs/jsc --dump-bytecode
> 1
4 m_instructions; 72 bytes at 0x1e21250; 1 parameter(s); 1 callee register(s)
[...]
> 
$ ./WebKitBuild/Debug/Programs/jsc --help
Usage: jsc [options] [files] [-- arguments]
  -e         Evaluate argument as script code
  -f         Specifies a source file (deprecated)
  -h|--help  Prints this help message
  -i         Enables interactive mode (default if no files are specified)
  -s         Installs signal handlers that exit on a crash (Unix platforms only)
  --dump-bytecode
             Dump all generated bytecode

In release mode:

$ ./WebKitBuild/Release/Programs/jsc --help
Usage: jsc [options] [files] [-- arguments]
  -e         Evaluate argument as script code
  -f         Specifies a source file (deprecated)
  -h|--help  Prints this help message
  -i         Enables interactive mode (default if no files are specified)
  -s         Installs signal handlers that exit on a crash (Unix platforms only)
$ ./WebKitBuild/Release/Programs/jsc --dump-bytecode
ERROR: This build has not been configured to allow the --dump-bytecode flag to be set at runtime.

Note the error.  In release mode, options that are not configurable compile to static methods that should inline appropriately, if I understand things right.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.