[Webkit-unassigned] [Bug 71262] Web Inspector: Add colorpicker functionality to color swatches in Styles Sidebar

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71262





--- Comment #9 from Pavel Feldman <pfeldman at chromium.org>  2011-11-20 10:21:57 PST ---
(In reply to comment #6)
> Copy that, I'll make the suggested changes.  Should I revert my initial changelog, and rebase all of the new changes into the initial commit, then generate a new changelog and patch?

I would re-build ChangeLog, yes.

(In reply to comment #7)
> Is there a certain css class or JavaScript function I can use to achieve the popover effect?
> 

Take a look at the Popover.js and the PopoverHelper there. It is basically a rich focusable tooltip control. I was going to suggest that you use it, but it hardcodes the yellowish background, so I was not sure it applies. It also disappears upon mouse move out, but that should be configurable. In either case you could at least re-use its utility code for positioning your box next to the anchor element.

(In reply to comment #8)
> There was supposed to be a checkerboard on the original swatch element, but now I see that it isn't updating properly.  I could do any of these:
>  * Make the swatch element update to show transparency (I think this is just a background image that isn't being applied)

That would be nice.

>  * Put a checkboard behind the actual colorpicker region and apply transparency to that.  I am not a huge fan of this, since when you have alpha it is hard to see the actual h/s/v you have chosen.

I would not do that as well.

>  * Show a label next to the transparency slider to make it clear that it is for changing alpha
>  * Show a text representation of currently selected color inside of the picker.  Note: this is currently happening in the actual value element that you are modifying, but it may be hard to see.

Yeah, that's what I meant. I now think you should mimic it inside the picker as well.

> I don't have any problem dropping the close button, it really doesn't look very good - I just used an existing icon from the project.

Lets see if clicking away / pressing Esc or toggling swatch back would be sufficient.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.