[Webkit-unassigned] [Bug 60931] crash after r86584 due to calling willRemoveWheelEventHandler too many times

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60931





--- Comment #11 from Julien Chaffraix <jchaffraix at webkit.org>  2011-11-19 07:45:19 PST ---
(From update of attachment 101882)
View in context: https://bugs.webkit.org/attachment.cgi?id=101882&action=review

The change looks sane to me but I think Andersca should give the final review as he knows the code a lot more than I do.

>>> Source/WebCore/ChangeLog:7
>>> +
>> 
>> It's unfortunate that there is no test case. The bug refers to 3 ASSERT in Chromium's test_expectations.txt, have you checked that your patch solves them? If it does not solve them, it looks like this is not a fix for the right bug. You would need an explanation as to why there is no test in this case.
> 
> These tests haven't crashed since the end of October, perhaps fixed by http://trac.webkit.org/changeset/98778/ (it's the only one in the span that mentions wheel events.  Any further info on this?

Fine enough, this change would need a test case then or an explanation as to why it lacks one as nothing seems to be checking that the calls are properly paired.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.