[Webkit-unassigned] [Bug 70895] Add WebCore platform interface needed by updated MediaStream API design

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70895





--- Comment #5 from Adam Barth <abarth at webkit.org>  2011-11-18 19:30:31 PST ---
(From update of attachment 115608)
View in context: https://bugs.webkit.org/attachment.cgi?id=115608&action=review

> Source/WebCore/platform/mediastream/MediaStreamCenter.cpp:38
> +#include "MediaStream.h"

Another issue is that MediaStream.h is outside the Platform directory and Platform isn't allowed to include headers from the rest of WebCore.

> Source/WebCore/platform/mediastream/MediaStreamCenter.cpp:48
> +MediaStreamCenter& MediaStreamCenter::instance()
> +{
> +    ASSERT(isMainThread());
> +    DEFINE_STATIC_LOCAL(MediaStreamCenter, center, ());
> +    return center;
> +}

The reason I ask these questions is that "static" is almost certainly the wrong scope for any state in WebKit.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.