[Webkit-unassigned] [Bug 72311] Inline caches that refer to otherwise dead objects should be cleared

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 18 15:32:27 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=72311





--- Comment #20 from Filip Pizlo <fpizlo at apple.com>  2011-11-18 15:32:27 PST ---
For Kraken, we see a similar effect to SunSpider: Not recompiling all JS functions is a regression, but then throwing this patch in brings us back to sanity.

Here's this patch, and not recompiling, against ToT;

TEST                         COMPARISON            FROM                 TO               DETAILS

====================================================================================

** TOTAL **:                 ??                3694.7ms +/- 0.5%   3733.9ms +/- 1.7%     might be *1.011x as slow*

====================================================================================

  ai:                        ??                 830.9ms +/- 1.5%    839.7ms +/- 0.3%     might be *1.011x as slow*
    astar:                   ??                 830.9ms +/- 1.5%    839.7ms +/- 0.3%     might be *1.011x as slow*

  audio:                     ??                 908.1ms +/- 0.4%    939.9ms +/- 7.0%     might be *1.035x as slow*
    beat-detection:          -                  218.0ms +/- 0.5%    215.9ms +/- 1.2% 
    dft:                     ??                 261.9ms +/- 0.4%    262.8ms +/- 0.7%     might be *1.003x as slow*
    fft:                     ??                 136.9ms +/- 1.0%    138.5ms +/- 1.7%     might be *1.012x as slow*
    oscillator:              ??                 291.3ms +/- 0.7%    322.7ms +/- 20.8%     might be *1.108x as slow*

  imaging:                   1.004x as fast    1187.6ms +/- 0.3%   1183.1ms +/- 0.2%     significant
    gaussian-blur:           -                  613.6ms +/- 0.7%    609.4ms +/- 0.2% 
    darkroom:                -                  333.8ms +/- 0.3%    332.3ms +/- 0.6% 
    desaturate:              ??                 240.2ms +/- 0.4%    241.4ms +/- 0.5%     might be *1.005x as slow*

  json:                      1.010x as fast     174.3ms +/- 0.4%    172.5ms +/- 0.3%     significant
    parse-financial:         1.012x as fast      85.3ms +/- 0.6%     84.3ms +/- 0.7%     significant
    stringify-tinderbox:     1.009x as fast      89.0ms +/- 0.7%     88.2ms +/- 0.3%     significant

  stanford:                  ??                 593.8ms +/- 0.5%    598.7ms +/- 0.8%     might be *1.008x as slow*
    crypto-aes:              ??                 127.5ms +/- 1.5%    128.1ms +/- 1.7%     might be *1.005x as slow*
    crypto-ccm:              ??                 130.3ms +/- 1.4%    131.0ms +/- 1.3%     might be *1.005x as slow*
    crypto-pbkdf2:           ??                 237.8ms +/- 0.8%    241.0ms +/- 1.3%     might be *1.013x as slow*
    crypto-sha256-iterative: ??                  98.2ms +/- 0.5%     98.6ms +/- 1.4%     might be *1.004x as slow*


And here's just not recompiling all JS functions versus ToT:

TEST                         COMPARISON            FROM                 TO               DETAILS

====================================================================================

** TOTAL **:                 *1.036x as slow*  3694.7ms +/- 0.5%   3826.6ms +/- 1.1%     significant

====================================================================================

  ai:                        -                  830.9ms +/- 1.5%    823.5ms +/- 1.9% 
    astar:                   -                  830.9ms +/- 1.5%    823.5ms +/- 1.9% 

  audio:                     *1.088x as slow*   908.1ms +/- 0.4%    988.0ms +/- 1.9%     significant
    beat-detection:          *1.082x as slow*   218.0ms +/- 0.5%    235.8ms +/- 2.3%     significant
    dft:                     *1.050x as slow*   261.9ms +/- 0.4%    275.1ms +/- 1.4%     significant
    fft:                     *1.150x as slow*   136.9ms +/- 1.0%    157.4ms +/- 3.3%     significant
    oscillator:              *1.097x as slow*   291.3ms +/- 0.7%    319.7ms +/- 2.0%     significant

  imaging:                   ??                1187.6ms +/- 0.3%   1189.5ms +/- 0.4%     might be *1.002x as slow*
    gaussian-blur:           -                  613.6ms +/- 0.7%    609.6ms +/- 0.2% 
    darkroom:                ??                 333.8ms +/- 0.3%    335.2ms +/- 1.0%     might be *1.004x as slow*
    desaturate:              *1.019x as slow*   240.2ms +/- 0.4%    244.7ms +/- 0.9%     significant

  json:                      *1.111x as slow*   174.3ms +/- 0.4%    193.7ms +/- 4.6%     significant
    parse-financial:         *1.138x as slow*    85.3ms +/- 0.6%     97.1ms +/- 5.9%     significant
    stringify-tinderbox:     *1.085x as slow*    89.0ms +/- 0.7%     96.6ms +/- 3.9%     significant

  stanford:                  *1.064x as slow*   593.8ms +/- 0.5%    631.9ms +/- 1.9%     significant
    crypto-aes:              *1.075x as slow*   127.5ms +/- 1.5%    137.1ms +/- 2.8%     significant
    crypto-ccm:              *1.085x as slow*   130.3ms +/- 1.4%    141.4ms +/- 4.2%     significant
    crypto-pbkdf2:           *1.068x as slow*   237.8ms +/- 0.8%    254.0ms +/- 2.4%     significant
    crypto-sha256-iterative: ??                  98.2ms +/- 0.5%     99.4ms +/- 1.7%     might be *1.012x as slow*

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list