[Webkit-unassigned] [Bug 72753] [WK2][Qt] Move Accelerated Composite animations to UIProcess

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72753


Noam Rosenthal <noam.rosenthal at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #115864|review?                     |review-
               Flag|                            |




--- Comment #2 from Noam Rosenthal <noam.rosenthal at nokia.com>  2011-11-18 15:14:59 PST ---
(From update of attachment 115864)
View in context: https://bugs.webkit.org/attachment.cgi?id=115864&action=review

Awesome! See comments, they are mainly nitpicks.

> Source/WebCore/ChangeLog:6
> +        Add helper method to synchronize animations.

... in TextureMapper.

> Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp:987
> +void TextureMapperNode::syncAnimationsRecursively(GraphicsLayerTextureMapper* graphicsLayer)

The argument might not be necessary. See next comment.

> Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp:994
> +        Vector<GraphicsLayer*> children = graphicsLayer->children();

You probably want to use the TextureMapperNode's children and not the graphicsLayer's children, otherwise you might be syncing animations for items that aren't in the synchronized tree yet.

> Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp:1000
> +        }

early return.

> Source/WebKit2/UIProcess/LayerTreeHostProxy.h:129
> +    void updateSceneGraphUpdateTimerFired(Timer<LayerTreeHostProxy>*);

I believe the convention is didFireViewportUpdateTimer

> Source/WebKit2/UIProcess/LayerTreeHostProxy.h:130
> +    Timer<LayerTreeHostProxy> m_sceneGraphUpdateTimer;

Let's use viewport instead of scenegraph

> Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:283
> +#if PLATFORM(QT)

Why QT only? This seems cross-platform. Nobody else uses WebGraphicsLayer yet so don't worry :)

> Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:306
> +#if PLATFORM(QT)

ditto

> Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:318
> +#if PLATFORM(QT)

ditto

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.