[Webkit-unassigned] [Bug 69870] [Chromium] Empty API for web intents

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69870


Greg Billock <gbillock at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #115418|1                           |0
        is obsolete|                            |




--- Comment #14 from Greg Billock <gbillock at google.com>  2011-11-18 14:57:33 PST ---
(From update of attachment 115418)
View in context: https://bugs.webkit.org/attachment.cgi?id=115418&action=review

>> Source/WebKit/chromium/public/WebFrame.h:556
>> +    virtual void replyFromIntentService(WebIntentsReplyType, const WebString&, int intentId) = 0;
> 
> How about calling this "handleIntentResult" or "handleIntentReply"?

As we discussed, changed to handleIntentResult and handleIntentFailure. The signatures can be evolved separately now if needed.

>> Source/WebKit/chromium/public/WebIntentServiceData.h:48
>> +class WebIntentServiceData {
> 
> nit: "Info" might be a better suffix for this class.  See for example WebPopupMenuInfo.

Done.

>> Source/WebKit/chromium/public/WebIntentServiceData.h:53
>> +    WEBKIT_EXPORT void setUrl(const WebURL&);
> 
> nit: setUrl should be setURL per the style guide

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.