[Webkit-unassigned] [Bug 72016] [Chromium] [WebSocket] export WebSocketChannel interface for plugins

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72016


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #115761|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #22 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2011-11-18 09:52:53 PST ---
(From update of attachment 115761)
View in context: https://bugs.webkit.org/attachment.cgi?id=115761&action=review

> Source/WebKit/chromium/src/WebSocket.cpp:43
> +    WebSocketImpl* websocket = new WebSocketImpl(document, client);

nit: WebKit style is to use OwnPtr here.

  OwnPtr<WebSocketImpl> websocket = adoptPtr(new WebSocketImpl(document, client));
  if (websocket && websocket->isNull())
      return 0;
  return websocket.leakPtr();

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.