[Webkit-unassigned] [Bug 72155] Replace Qt QThread threading back-end with pthread/Win32 threading back-ends

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72155





--- Comment #9 from Andrew Wason <rectalogic at rectalogic.com>  2011-11-18 09:22:38 PST ---
(In reply to comment #6)
> > Source/WebKit/qt/Api/qwebsettings.cpp:311
> > +    if (!global) {
> > +        WebCore::ScriptController::initializeThreading();
> >          global = new QWebSettings;
> > +    }
> 
> Actually we call this already in QWebPagePagePrivate. Are you sure you need it here?

Yes, global QWebSettings can be used before any QWebPage is created - and some settings (e.g. page cache settings) rely on threading being initialized.  QtTestBrowser does this and asserts without the above.

> If yes, then we should move all those initializations into a central function that we can call
> from QWebPagePrivate as well as from here. I don't like the idea of sprinkling Foo::initializeBar()
> over the code :)

Do you mean extract all the global webkit initialization code (e.g. the first 10 lines of QWebPagePrivate::QWebPagePrivate) into some initializeWebKit() function that is called from QWebPagePrivate and QWebSettings::globalSettings?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.