[Webkit-unassigned] [Bug 72155] Replace Qt QThread threading back-end with pthread/Win32 threading back-ends

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72155


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #114751|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #6 from Simon Hausmann <hausmann at webkit.org>  2011-11-18 00:19:22 PST ---
(From update of attachment 114751)
View in context: https://bugs.webkit.org/attachment.cgi?id=114751&action=review

Patch looks good to me! Except for the initialization bit (see comment below). So r- just to clarify that, but otherwise nice cleanup! :)

> Source/WebKit/qt/Api/qwebsettings.cpp:311
> +    if (!global) {
> +        WebCore::ScriptController::initializeThreading();
>          global = new QWebSettings;
> +    }

Actually we call this already in QWebPagePagePrivate. Are you sure you need it here?

If yes, then we should move all those initializations into a central function that we can call from QWebPagePrivate as well as from here. I don't like the idea of
sprinkling Foo::initializeBar() over the code :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.