[Webkit-unassigned] [Bug 71703] REGRESSION(r98542): Chromium: CSS text is rendered on page

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 17 23:02:25 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=71703





--- Comment #45 from Luke Macpherson <macpherson at chromium.org>  2011-11-17 23:02:24 PST ---
(From update of attachment 115738)
View in context: https://bugs.webkit.org/attachment.cgi?id=115738&action=review

> Source/WebCore/css/CSSStyleSelector.cpp:1268
>      ensureDefaultStyleSheetsForElement(element);

I think it would be clearer to either:
1) Make ensureDefualtStyleSheetsForElement return a boolean indicating that the cache needs to be invalidated because the default style has changed, or
2) to use a setter that automatically clears the cache when called.
As it is this code is essentially watching to see if a side-effect has occurred, which makes the intent less clear than it could be.

Another solution might be something like:
if (simpleDefaultStyleSheet && !elementCanUseSimpleDefaultStyle(element))
    return s_styleNotYetAvailable;
(Not 100% sure on that, but Antti should know.)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list