[Webkit-unassigned] [Bug 72311] Inline caches that refer to otherwise dead objects should be cleared

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 17 22:24:48 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=72311





--- Comment #11 from Filip Pizlo <fpizlo at apple.com>  2011-11-17 22:24:48 PST ---
Well, I can't get the 0.8% V8 slow-down to repro on any of my three machines.  I'm going to say that this is perf-neutral.



[pizlo at nitroflex bencher] ./bencher TipOfTree:/Volumes/Data/pizlo/quinary/OpenSource/WebKitBuild/Release/jsc WeakCaches:/Volumes/Data/pizlo/secondary/OpenSource/WebKitBuild/Release/jsc --remote oldmac,bigmac --local
Packaging VM builds for remote hosts...
Sending VM builds to oldmac...
Running on oldmac...
376/376                                                         
Generating benchmark report at TipOfTree_WeakCaches_SunSpiderV8Kraken_20111117_2215_benchReport.txt

Benchmark report for SunSpider, V8, and Kraken on oldmac.local (MacPro4,1).

VMs tested:
"TipOfTree" at /Volumes/Data/pizlo/quinary/OpenSource/WebKitBuild/Release/jsc (r100674)
"WeakCaches" at /Volumes/Data/pizlo/secondary/OpenSource/WebKitBuild/Release/jsc (r100674)

Collected 12 samples per benchmark/VM, with 4 VM invocations per benchmark. Emitted a call to gc() between sample
measurements. Used 1 benchmark iteration per VM invocation for warm-up. Used the jsc-specific preciseTime()
function to get microsecond-level timing. Reporting benchmark execution times with 95% confidence intervals in
milliseconds.

                                            TipOfTree               WeakCaches                                   
SunSpider:
   3d-cube                                8.8947+-0.0400    ?     8.9120+-0.0378       ?
   3d-morph                              10.1878+-0.0429         10.1173+-0.0649       
   3d-raytrace                            9.1729+-0.0690    ?     9.2488+-0.0730       ?
   access-binary-trees                    1.9086+-0.0098    ?     1.9167+-0.0063       ?
   access-fannkuch                        9.0967+-0.0116    ?     9.1367+-0.0876       ?
   access-nbody                           5.0368+-0.0056    ?     5.0442+-0.0069       ?
   access-nsieve                          3.7415+-0.0431          3.7128+-0.0060       
   bitops-3bit-bits-in-byte               1.4913+-0.0132    ?     1.5021+-0.0167       ?
   bitops-bits-in-byte                    5.9335+-0.0079          5.9224+-0.0140       
   bitops-bitwise-and                     3.9795+-0.0087          3.9756+-0.0143       
   bitops-nsieve-bits                     6.8585+-0.0446          6.8020+-0.0472       
   controlflow-recursive                  2.7623+-0.0183    ?     2.7647+-0.0136       ?
   crypto-aes                             8.6855+-0.0931          8.6660+-0.0754       
   crypto-md5                             2.9867+-0.0080    ?     2.9877+-0.0124       ?
   crypto-sha1                            2.6099+-0.0191    ?     2.6214+-0.0294       ?
   date-format-tofte                     12.8921+-0.1053    ?    13.0743+-0.1502       ? might be 1.0141x slower
   date-format-xparb                     14.6301+-0.1444         14.4959+-0.1759       
   math-cordic                            8.6518+-0.0400          8.6261+-0.0172       
   math-partial-sums                     12.6500+-0.0440         12.6309+-0.0280       
   math-spectral-norm                     3.1304+-0.0155          3.1296+-0.0072       
   regexp-dna                            15.7034+-0.0536    ?    15.7611+-0.0604       ?
   string-base64                          4.7400+-0.0370    ?     4.7764+-0.0342       ?
   string-fasta                           8.9695+-0.0621    ?     8.9759+-0.0260       ?
   string-tagcloud                       15.8240+-0.0888         15.7925+-0.1060       
   string-unpack-code                    27.5915+-0.1673         27.5327+-0.0761       
   string-validate-input                  6.7825+-0.0632    ?     6.8006+-0.0838       ?

   <arithmetic> *                         8.2658+-0.0266    ?     8.2664+-0.0292       ? might be 1.0001x slower
   <geometric>                            6.5344+-0.0204    ?     6.5383+-0.0242       ? might be 1.0006x slower
   <harmonic>                             5.0544+-0.0154    ?     5.0626+-0.0211       ? might be 1.0016x slower

                                            TipOfTree               WeakCaches                                   
V8:
   crypto                                93.2477+-0.3185    ?    93.7770+-0.4298       ?
   deltablue                            204.1601+-1.0130    !   206.3418+-0.8906       ! definitely 1.0107x slower
   earley-boyer                         124.6204+-0.2962    ?   126.0559+-1.2859       ? might be 1.0115x slower
   raytrace                              77.2042+-0.9266         76.3591+-0.3855         might be 1.0111x faster
   regexp                               148.3235+-0.2242    ?   148.4812+-0.3107       ?
   richards                             166.8579+-1.5676    ?   167.0018+-0.8833       ?
   splay                                106.7798+-1.2362        106.2237+-0.8954       

   <arithmetic>                         131.5991+-0.3795    ?   132.0343+-0.3261       ? might be 1.0033x slower
   <geometric> *                        125.2613+-0.3946    ?   125.5044+-0.3336       ? might be 1.0019x slower
   <harmonic>                           119.2370+-0.4347    ?   119.2910+-0.3460       ? might be 1.0005x slower

                                            TipOfTree               WeakCaches                                   
Kraken:
   ai-astar                             895.2102+-0.5776    ?   895.3543+-0.8576       ?
   audio-beat-detection                 248.4783+-0.5454    !   251.2638+-1.9747       ! definitely 1.0112x slower
   audio-dft                            314.4556+-2.8743        313.9113+-2.8510       
   audio-fft                            161.9779+-0.2354    ?   162.3217+-0.8390       ?
   audio-oscillator                     355.3719+-2.8833        347.5008+-5.6341         might be 1.0227x faster
   imaging-darkroom                     407.3586+-6.4591        406.5261+-6.6644       
   imaging-desaturate                   291.1644+-0.0432    ?   291.1873+-0.0935       ?
   imaging-gaussian-blur                751.0524+-0.2825        750.7334+-0.1394       
   json-parse-financial                  88.8708+-0.4604    ?    89.3269+-0.3017       ?
   json-stringify-tinderbox             104.3903+-0.2122        104.2862+-0.3965       
   stanford-crypto-aes                  139.9116+-0.7371    !   145.5284+-3.5541       ! definitely 1.0401x slower
   stanford-crypto-ccm                  137.4390+-0.5954    !   140.8775+-1.1446       ! definitely 1.0250x slower
   stanford-crypto-pbkdf2               281.6578+-2.1680    ?   284.5136+-2.4063       ? might be 1.0101x slower
   stanford-crypto-sha256-iterative     113.8772+-0.7313    ^   112.6475+-0.3416       ^ definitely 1.0109x faster

   <arithmetic> *                       306.5154+-0.6597    ?   306.8556+-0.6732       ? might be 1.0011x slower
   <geometric>                          239.5670+-0.4735    ?   240.4821+-0.5706       ? might be 1.0038x slower
   <harmonic>                           194.1157+-0.2640    !   195.2375+-0.4884       ! definitely 1.0058x slower

                                            TipOfTree               WeakCaches                                   
All benchmarks:
   <arithmetic>                         115.4749+-0.1876    ?   115.6414+-0.2313       ? might be 1.0014x slower
   <geometric>                           29.6598+-0.0535    ?    29.7120+-0.0822       ? might be 1.0018x slower
   <harmonic>                             8.9102+-0.0264    ?     8.9250+-0.0367       ? might be 1.0017x slower

                                            TipOfTree               WeakCaches                                   
Geomean of preferred means:
   <scaled-result>                       68.2101+-0.1005    ?    68.2813+-0.1651       ? might be 1.0010x slower

Sending VM builds to bigmac...
Running on bigmac...
376/376                                                         
Generating benchmark report at TipOfTree_WeakCaches_SunSpiderV8Kraken_20111117_2217_benchReport.txt

Benchmark report for SunSpider, V8, and Kraken on bigmac.local (MacPro5,1).

VMs tested:
"TipOfTree" at /Volumes/Data/pizlo/quinary/OpenSource/WebKitBuild/Release/jsc (r100674)
"WeakCaches" at /Volumes/Data/pizlo/secondary/OpenSource/WebKitBuild/Release/jsc (r100674)

Collected 12 samples per benchmark/VM, with 4 VM invocations per benchmark. Emitted a call to gc() between sample
measurements. Used 1 benchmark iteration per VM invocation for warm-up. Used the jsc-specific preciseTime()
function to get microsecond-level timing. Reporting benchmark execution times with 95% confidence intervals in
milliseconds.

                                            TipOfTree               WeakCaches                                   
SunSpider:
   3d-cube                                7.4087+-0.0348    ?     7.4240+-0.0413       ?
   3d-morph                               8.4219+-0.0381          8.3901+-0.0348       
   3d-raytrace                            7.6843+-0.0588    ?     7.7228+-0.0446       ?
   access-binary-trees                    1.5952+-0.0034    ?     1.6041+-0.0109       ?
   access-fannkuch                        7.5366+-0.0133          7.5282+-0.0137       
   access-nbody                           4.1748+-0.0094    ?     4.1847+-0.0062       ?
   access-nsieve                          3.1552+-0.0510    ?     3.1602+-0.0537       ?
   bitops-3bit-bits-in-byte               1.2371+-0.0114    !     1.2710+-0.0135       ! definitely 1.0274x slower
   bitops-bits-in-byte                    4.9017+-0.0150    ?     4.9113+-0.0445       ?
   bitops-bitwise-and                     3.3292+-0.0417          3.2868+-0.0042         might be 1.0129x faster
   bitops-nsieve-bits                     5.6784+-0.0604          5.6720+-0.0439       
   controlflow-recursive                  2.3014+-0.0217          2.3001+-0.0263       
   crypto-aes                             7.2437+-0.1201          7.1714+-0.0298         might be 1.0101x faster
   crypto-md5                             2.5080+-0.0209    ?     2.5095+-0.0196       ?
   crypto-sha1                            2.1831+-0.0268          2.1817+-0.0189       
   date-format-tofte                     10.6713+-0.0589         10.6563+-0.0450       
   date-format-xparb                     11.6481+-0.1539         11.5045+-0.0940         might be 1.0125x faster
   math-cordic                            7.1305+-0.0232    ?     7.1495+-0.0339       ?
   math-partial-sums                     10.4843+-0.0197         10.4432+-0.0333       
   math-spectral-norm                     2.5910+-0.0039    !     2.5997+-0.0048       ! definitely 1.0033x slower
   regexp-dna                            12.9868+-0.0526    ?    13.0635+-0.0692       ?
   string-base64                          3.9365+-0.0268    ?     3.9666+-0.0297       ?
   string-fasta                           7.4048+-0.0224    ?     7.4262+-0.0165       ?
   string-tagcloud                       13.0262+-0.0455         13.0190+-0.0588       
   string-unpack-code                    22.2219+-0.0879    ?    22.3529+-0.0763       ?
   string-validate-input                  5.5902+-0.0317    ?     5.6688+-0.1341       ? might be 1.0141x slower

   <arithmetic> *                         6.8096+-0.0205    ?     6.8142+-0.0190       ? might be 1.0007x slower
   <geometric>                            5.4124+-0.0170    ?     5.4207+-0.0192       ? might be 1.0015x slower
   <harmonic>                             4.2025+-0.0160    ?     4.2207+-0.0199       ? might be 1.0043x slower

                                            TipOfTree               WeakCaches                                   
V8:
   crypto                                77.4580+-0.2994         77.2495+-0.2422       
   deltablue                            170.5089+-1.6666    ?   171.7374+-1.6703       ?
   earley-boyer                         103.7700+-0.3527    ?   105.3101+-1.2086       ? might be 1.0148x slower
   raytrace                              64.5108+-0.5795         63.6362+-0.6552         might be 1.0137x faster
   regexp                               124.3676+-0.2792    ?   124.6022+-0.4107       ?
   richards                             138.5908+-1.5768        137.8858+-0.2496       
   splay                                 90.4342+-1.0799         89.7729+-0.7036       

   <arithmetic>                         109.9486+-0.3112    ?   110.0277+-0.4246       ? might be 1.0007x slower
   <geometric> *                        104.6810+-0.2393        104.6085+-0.3968         might be 1.0007x faster
   <harmonic>                            99.6635+-0.2604         99.4283+-0.3943         might be 1.0024x faster

                                            TipOfTree               WeakCaches                                   
Kraken:
   ai-astar                             827.0655+-0.1641    ^   808.7910+-12.4758      ^ definitely 1.0226x faster
   audio-beat-detection                 204.6192+-0.9188    ?   205.8697+-0.5044       ?
   audio-dft                            261.1092+-2.7787    ?   261.6707+-2.5628       ?
   audio-fft                            132.9265+-0.1194    ?   133.3967+-0.7447       ?
   audio-oscillator                     294.3907+-1.3264    ^   283.8631+-4.8283       ^ definitely 1.0371x faster
   imaging-darkroom                     334.8023+-4.7179    ?   337.4471+-5.7008       ?
   imaging-desaturate                   240.9506+-0.2240    ?   240.9684+-0.1227       ?
   imaging-gaussian-blur                620.7693+-0.2246    ?   621.6854+-2.1459       ?
   json-parse-financial                  73.2406+-0.2254    ?    73.3942+-0.1276       ?
   json-stringify-tinderbox              86.7271+-0.3576    ?    87.4358+-0.7803       ?
   stanford-crypto-aes                  116.6774+-0.8003    !   119.6183+-1.5563       ! definitely 1.0252x slower
   stanford-crypto-ccm                  114.4313+-0.6022    !   117.6416+-0.8032       ! definitely 1.0281x slower
   stanford-crypto-pbkdf2               232.5902+-0.9980    ?   233.7615+-0.2435       ?
   stanford-crypto-sha256-iterative      93.1953+-0.4072         92.8300+-0.2839       

   <arithmetic> *                       259.5354+-0.3681        258.4553+-1.1468         might be 1.0042x faster
   <geometric>                          199.5816+-0.2810    ?   199.9460+-0.5338       ? might be 1.0018x slower
   <harmonic>                           160.6941+-0.2299    !   161.5873+-0.4243       ! definitely 1.0056x slower

                                            TipOfTree               WeakCaches                                   
All benchmarks:
   <arithmetic>                          97.4508+-0.1245         97.1433+-0.3842         might be 1.0032x faster
   <geometric>                           24.6421+-0.0479    ?    24.6739+-0.0627       ? might be 1.0013x slower
   <harmonic>                             7.4085+-0.0276    ?     7.4400+-0.0343       ? might be 1.0043x slower

                                            TipOfTree               WeakCaches                                   
Geomean of preferred means:
   <scaled-result>                       56.9807+-0.0741         56.9008+-0.1544         might be 1.0014x faster

Running locally...
376/376                                                         
Generating benchmark report at TipOfTree_WeakCaches_SunSpiderV8Kraken_20111117_2220_benchReport.txt

Benchmark report for SunSpider, V8, and Kraken on nitroflex.local (MacBookPro8,2).

VMs tested:
"TipOfTree" at /Volumes/Data/pizlo/quinary/OpenSource/WebKitBuild/Release/jsc (r100674)
"WeakCaches" at /Volumes/Data/pizlo/secondary/OpenSource/WebKitBuild/Release/jsc (r100674)

Collected 12 samples per benchmark/VM, with 4 VM invocations per benchmark. Emitted a call to gc() between sample
measurements. Used 1 benchmark iteration per VM invocation for warm-up. Used the jsc-specific preciseTime()
function to get microsecond-level timing. Reporting benchmark execution times with 95% confidence intervals in
milliseconds.

                                            TipOfTree               WeakCaches                                   
SunSpider:
   3d-cube                                6.8386+-0.1369    ?     6.8670+-0.1591       ?
   3d-morph                               7.6310+-0.1445    ?     7.6571+-0.1262       ?
   3d-raytrace                            7.1236+-0.2343    ?     7.1748+-0.2134       ?
   access-binary-trees                    1.5442+-0.0588    ?     1.5591+-0.0798       ?
   access-fannkuch                        6.0392+-0.0580    ?     6.0908+-0.0779       ?
   access-nbody                           3.4093+-0.0749    ?     3.4874+-0.0651       ? might be 1.0229x slower
   access-nsieve                          2.4843+-0.0658    ?     2.5331+-0.0456       ? might be 1.0196x slower
   bitops-3bit-bits-in-byte               1.2400+-0.0208    ?     1.2768+-0.0424       ? might be 1.0297x slower
   bitops-bits-in-byte                    2.3495+-0.0581    ?     2.3848+-0.0675       ? might be 1.0150x slower
   bitops-bitwise-and                     3.3964+-0.0650    ?     3.4162+-0.0689       ?
   bitops-nsieve-bits                     5.2170+-0.0571          5.2053+-0.0867       
   controlflow-recursive                  2.0306+-0.0478    ?     2.0796+-0.0331       ? might be 1.0242x slower
   crypto-aes                             6.8778+-0.1170    ?     7.0300+-0.2004       ? might be 1.0221x slower
   crypto-md5                             2.3851+-0.0759    ?     2.4297+-0.0920       ? might be 1.0187x slower
   crypto-sha1                            2.0545+-0.0494    ?     2.0873+-0.0506       ? might be 1.0159x slower
   date-format-tofte                      9.9825+-0.1603    ?    10.0566+-0.2186       ?
   date-format-xparb                     10.9696+-0.2362         10.8717+-0.1573       
   math-cordic                            6.2295+-0.1010    ?     6.4359+-0.1099       ? might be 1.0331x slower
   math-partial-sums                      7.4259+-0.2035          7.3829+-0.1104       
   math-spectral-norm                     2.3528+-0.0510    ?     2.3738+-0.0618       ?
   regexp-dna                            10.7878+-0.1746    ?    11.0114+-0.1540       ? might be 1.0207x slower
   string-base64                          3.9457+-0.1976          3.8035+-0.0783         might be 1.0374x faster
   string-fasta                           6.5032+-0.1164    ?     6.5834+-0.0730       ? might be 1.0123x slower
   string-tagcloud                       11.6524+-0.3080         11.5740+-0.3664       
   string-unpack-code                    19.9997+-0.4005         19.9907+-0.3590       
   string-validate-input                  5.1990+-0.0807    ?     5.3495+-0.1241       ? might be 1.0290x slower

   <arithmetic> *                         5.9873+-0.0255    ?     6.0274+-0.0266       ? might be 1.0067x slower
   <geometric>                            4.7571+-0.0258    ?     4.8038+-0.0274       ? might be 1.0098x slower
   <harmonic>                             3.7479+-0.0331    ?     3.7974+-0.0372       ? might be 1.0132x slower

                                            TipOfTree               WeakCaches                                   
V8:
   crypto                                69.7311+-0.5761         69.5905+-0.3407       
   deltablue                            149.6033+-1.6382    ?   149.9671+-0.7672       ?
   earley-boyer                          84.8068+-0.3751    ?    85.0753+-0.9961       ?
   raytrace                              56.2134+-1.2250    ?    56.3687+-0.4111       ?
   regexp                               102.2150+-0.5761    ?   102.4564+-0.4019       ?
   richards                             116.4703+-0.5039        116.3584+-0.3244       
   splay                                 71.1878+-0.5781    ?    71.5626+-1.1676       ?

   <arithmetic>                          92.8897+-0.3338    ?    93.0542+-0.2930       ? might be 1.0018x slower
   <geometric> *                         88.3791+-0.3757    ?    88.5463+-0.3139       ? might be 1.0019x slower
   <harmonic>                            84.2935+-0.4672    ?    84.4659+-0.3292       ? might be 1.0020x slower

                                            TipOfTree               WeakCaches                                   
Kraken:
   ai-astar                             481.0555+-1.9411    ?   485.7408+-2.9128       ?
   audio-beat-detection                 188.1320+-1.5393        187.1138+-0.5824       
   audio-dft                            261.1059+-1.8659    ?   261.7865+-3.1228       ?
   audio-fft                            122.5034+-0.6345        122.3092+-0.8059       
   audio-oscillator                     248.3586+-0.9176        245.8170+-1.7807         might be 1.0103x faster
   imaging-darkroom                     297.2359+-4.1428        296.1308+-3.6880       
   imaging-desaturate                   222.0842+-2.6411    ?   223.2395+-1.2428       ?
   imaging-gaussian-blur                543.6976+-2.9637    ?   543.7442+-1.7596       ?
   json-parse-financial                  57.2787+-0.3301         57.1892+-0.1696       
   json-stringify-tinderbox              73.8504+-0.9164         72.7696+-0.3363         might be 1.0149x faster
   stanford-crypto-aes                   96.0850+-1.2172         95.0746+-0.6106         might be 1.0106x faster
   stanford-crypto-ccm                   98.6912+-0.5641    ?    99.9238+-0.7357       ? might be 1.0125x slower
   stanford-crypto-pbkdf2               188.1711+-1.7414        187.2750+-3.1966       
   stanford-crypto-sha256-iterative      79.4168+-0.3274         79.3875+-0.9256       

   <arithmetic> *                       211.2619+-0.3660        211.2501+-0.5707         might be 1.0001x faster
   <geometric>                          168.9592+-0.3150        168.6816+-0.4400         might be 1.0016x faster
   <harmonic>                           136.4769+-0.2737        136.1003+-0.3651         might be 1.0028x faster

                                            TipOfTree               WeakCaches                                   
All benchmarks:
   <arithmetic>                          80.0758+-0.1373    ?    80.1190+-0.1897       ? might be 1.0005x slower
   <geometric>                           21.2897+-0.0651    ?    21.4006+-0.0718       ? might be 1.0052x slower
   <harmonic>                             6.5985+-0.0569    ?     6.6832+-0.0637       ? might be 1.0128x slower

                                            TipOfTree               WeakCaches                                   
Geomean of preferred means:
   <scaled-result>                       48.1720+-0.0816    ?    48.3091+-0.1069       ? might be 1.0028x slower

[pizlo at nitroflex bencher]

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list