[Webkit-unassigned] [Bug 72680] New: create a "SystemHost" object for webkitpy to slim down the Host object
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 17 17:07:44 PST 2011
https://bugs.webkit.org/show_bug.cgi?id=72680
Summary: create a "SystemHost" object for webkitpy to slim down
the Host object
Product: WebKit
Version: 528+ (Nightly build)
Platform: Unspecified
OS/Version: Unspecified
Status: NEW
Severity: Normal
Priority: P2
Component: Tools / Tests
AssignedTo: webkit-unassigned at lists.webkit.org
ReportedBy: dpranke at chromium.org
CC: eric at webkit.org, abarth at webkit.org
There has been a bunch of work lately to consolidate factories into a Host object in webkitpy for easier testing. This is a good goal, but the Host object imports a bunch of network/service-level objects and introduces a number of dependencies; it makes the dependencies of objects that use Host harder to understand.
I think it would make sense to have a thinner object (call it a SystemHost) that only contains the objects from webkitpy.common.system in Host, and modify some of the factories and constructors like Port and PortFactory to take SystemHosts instead, so it can be clear(er?) that they may depend on FileSystem, User, etc. but don't depend on Buildbot, Bugzilla, etc.
The Host object can then subclass the SystemHost object.
Sound good?
-- Dirk
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list