[Webkit-unassigned] [Bug 72597] [Qt] Layer violation: ThirdPartyCookiesQt.cpp uses QWebSettings in two places

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72597





--- Comment #3 from Simon Hausmann <hausmann at webkit.org>  2011-11-17 12:01:25 PST ---
(In reply to comment #2)
> (From update of attachment 115577 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=115577&action=review
> 
> > Source/WebKit/qt/Api/qwebsettings.cpp:401
> >  
> 
> All the other settings have a verb, Always_allow_, etc. Perhaps UseGlobalSetting? Come to think of it, isn't this handled by "If a setting is not configured, then it is looked
> up in the global settings object, which can be accessed using globalSettings()". Ie, do we need an enum for it, or is the behavior enough?

Yeah the main issue is that the "inheritance" of settings from global settings only works for things that can be enabled, disabled or unset. For the enum the "unset" option is what the patch adds.

Another option would be to just keep the old behaviour and say that the setting only has an effect on QWebSettings::globalSettings(). But now that we _can_ support it per page, we might as well.

How about QWebSettings::UseGlobalThirdPartyCookieSetting ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.