[Webkit-unassigned] [Bug 70895] Add WebCore platform interface needed by updated MediaStream API design

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70895





--- Comment #2 from Adam Barth <abarth at webkit.org>  2011-11-17 10:20:08 PST ---
(From update of attachment 115608)
View in context: https://bugs.webkit.org/attachment.cgi?id=115608&action=review

> Source/WebCore/platform/mediastream/MediaStreamCenter.cpp:57
> +void MediaStreamCenter::endLocalMediaStream(MediaStreamDescriptor* streamDescriptor)
> +{
> +    MediaStream* stream = streamDescriptor->owner();
> +    if (stream)
> +        stream->streamEnded();
> +    else
> +        streamDescriptor->setEnded();
> +}

This function doesn't appear to have any callers.  Why wouldn't the callers just do this work directly?  What's the value in having a static MediaStreamCenter to help?

> Source/WebCore/platform/mediastream/MediaStreamCenter.h:44
> +class MediaStreamCenter {

Can you help me understand what role the MediaStreamCenter plays?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.