[Webkit-unassigned] [Bug 72525] [GTK] Consider parent AtkObject in webkit_accessible_get_parent(), if already set

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72525


Xan Lopez <xan.lopez at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #115411|review?                     |review-
               Flag|                            |




--- Comment #3 from Xan Lopez <xan.lopez at gmail.com>  2011-11-17 02:06:04 PST ---
(From update of attachment 115411)
View in context: https://bugs.webkit.org/attachment.cgi?id=115411&action=review

> Source/WebKit/gtk/tests/testatk.c:1669
> +    g_assert(atk_object_get_parent(axRoot) == axButton);

I think it would be useful to expand the test a bit:

- Add the view to an offscreen window. Get the parent. Should be the window.
- Now set_parent to the button, like you do now. Now get_parent should be the button, not the window.

Hope that makes sense, that way we check the base case works and that the transition happens correctly.

Looks good to me otherwise!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.