[Webkit-unassigned] [Bug 72312] DFG code blocks that have speculation checks on objects should refer to those objects weakly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72312


Filip Pizlo <fpizlo at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #115517|0                           |1
        is obsolete|                            |
 Attachment #115537|                            |review?
               Flag|                            |




--- Comment #3 from Filip Pizlo <fpizlo at apple.com>  2011-11-17 00:00:20 PST ---
Created an attachment (id=115537)
 --> (https://bugs.webkit.org/attachment.cgi?id=115537&action=review)
the patch

Fixed 32-bit build.  All tests pass, performance is neutral.  Verified with printf's that the code was actually doing things; it was, and as expected: most code blocks find all their weak references to be live on the first pass, and all code blocks eventually always find all of their weak references to be live in the benchmarks we track.  The latter is true mainly because we still treat references from inline caches to be strong.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.