[Webkit-unassigned] [Bug 71791] [EFL] Add show and hide control for ewk tiled backing store.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71791





--- Comment #14 from Grzegorz <g.czajkowski at samsung.com>  2011-11-16 23:05:12 PST ---
(In reply to comment #13)
> (In reply to comment #12)
> > View in context: https://bugs.webkit.org/attachment.cgi?id=115344&action=review
> > 
> > > Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp:415
> > > +        return false;
> > 
> > I am wondering if we really have to return false in this case. The function tends to return false only in case of failures like:
> > if (!tile)
> >    return false;
> > 
> > In case of:
> > else if (old->row == currentRow && old->col == currentColumn && old->zoom == zoom)
> >    goto end; // true is returned
> > 
> > I would rather hear specialists of backing store about this.
> From _ewk_tiled_backing_store_item_add api, you can notice the reason why this must be false. :)

In thie case LGTM,

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.