[Webkit-unassigned] [Bug 72467] Code block jettisoning should be part of the GC's transitive closure

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72467


Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #115333|                            |review+
               Flag|                            |




--- Comment #7 from Geoffrey Garen <ggaren at apple.com>  2011-11-16 14:48:34 PST ---
(From update of attachment 115333)
View in context: https://bugs.webkit.org/attachment.cgi?id=115333&action=review

r=me -- but make sure to check in the version that builds on Windows.

> Source/JavaScriptCore/bytecode/CodeBlock.h:1109
> +                : isMarked(false)

Let's reserve the word "mark" for things with standard mark bits, and call this "mightBeExecuting".

> Source/JavaScriptCore/heap/DFGCodeBlocks.cpp:46
> +    for (unsigned i = 0; i < toRemove.size(); ++i) {

You can use Vector's deleteAllValues here.

> Source/JavaScriptCore/heap/DFGCodeBlocks.cpp:85
> +    for (unsigned i = 0; i < toRemove.size(); ++i) {

Helper function here too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.