[Webkit-unassigned] [Bug 72178] Fix mixed content handling for AssociatedURLLoader.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72178





--- Comment #7 from Aaron Colwell <acolwell at chromium.org>  2011-11-16 14:03:29 PST ---
(In reply to comment #6)
> I wonder why the checks aren't applied in the first place. Doesn't the loader use a threadable loader which in turn uses a cached resource loader that should apply the correct checks?

So it appears that you are correct that AssociatedURLLoader creates a DocumentThreadableLoader which creates a CachedResourceLoader via CachedResourceLoader::requestRawResource(). Since the CachedResourceLoader has a type of RawResource the display checks are skipped. 

How about this for a fix:
1. Add a MediaResource to CachedResource::Type
2. Update switch() statements in CachedResourceLoader
3. Create the inverse of cachedResourceTypeToTargetType() that maps ResourceRequest::TargetType to CachedResource::Type
4. Update DocumentThreadableLoader::loadRequest() to use the new mapping function to determine what type of CachedResourceLoader() to create instead of always creating a RawResource CachedResource.

I believe this should fix the problem and possibly fix any other TargetTypes that happen to be getting loaded through DocumentThreadableLoader.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.