[Webkit-unassigned] [Bug 68324] [Gtk] metaKey modifier is not working with eventSender object

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68324


Xan Lopez <xan.lopez at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #107789|review?                     |review-
               Flag|                            |




--- Comment #2 from Xan Lopez <xan.lopez at gmail.com>  2011-11-16 11:49:00 PST ---
(From update of attachment 107789)
View in context: https://bugs.webkit.org/attachment.cgi?id=107789&action=review

Looks good overall, r- for a few small comments. Thanks for the patch!

> Tools/DumpRenderTree/gtk/EventSender.cpp:281
>      else if (JSStringIsEqualToUTF8CString(string, "metaKey"))

The indentation seems to be a bit screwed here?

> LayoutTests/ChangeLog:9
> +        using evnetSender object.

s/evnet/event/

> LayoutTests/platform/gtk/fast/events/event-sender-metakey.html:13
> +            return;

This seems a bit unnecessary? I'd just have metakey =false; <events with no metakey>; metakey = true; <events with metakey>; and set failed to true if the invariant breaks at any point?

> LayoutTests/platform/gtk/fast/events/event-sender-metakey.html:38
> +    resultDiv.innerHTML = (true == failed) ? "FAIL" : "PASS";

Simply failed?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.