[Webkit-unassigned] [Bug 70897] Use a simple page client for user consent in getUserMedia()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70897


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #115412|review?                     |review+, commit-queue+
               Flag|                            |




--- Comment #34 from Adam Barth <abarth at webkit.org>  2011-11-16 11:23:42 PST ---
(From update of attachment 115412)
View in context: https://bugs.webkit.org/attachment.cgi?id=115412&action=review

I think we should land this patch so we can move forward.  This patch is generally very good.  I have one memory-safety concern abou the lifetime of the UserMediaClient, which I've noted below, but we can address that issue in a follow-up patch.  Thanks again for iterating on this patch.

> Source/WebCore/mediastream/UserMediaRequest.cpp:105
> +    if (m_client) {
> +        m_client->cancelUserMediaRequest(this);
> +        m_client = 0;
> +    }

What is the lifetime of the UserMediaClient?  In particular, can a document out-live the client?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.