[Webkit-unassigned] [Bug 72294] Add contains() test to Region

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72294





--- Comment #30 from Dana Jansens <danakj at chromium.org>  2011-11-16 10:54:34 PST ---
(In reply to comment #29)
> (From update of attachment 115406 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=115406&action=review
> 
> > Source/WebCore/platform/graphics/Region.h:51
> > +    bool contains(const Region&) const { return WebCore::intersect(region, *this).m_shape == region.m_shape; }
> 
> This won’t compile because the argument name, region, was omitted.

Oh sorry, moved things last second.

> > Source/WebCore/platform/graphics/Region.h:114
> > +        friend bool operator!=(const Shape&, const Shape&);
> 
> I don’t think != needs to be a friend.

It does because Region::Shape is private, it won't compile otherwise.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.