[Webkit-unassigned] [Bug 72500] [GTK] Use a URI instead of local path to create download destination in WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72500


Philippe Normand <pnormand at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #115371|review?                     |review+
               Flag|                            |




--- Comment #2 from Philippe Normand <pnormand at igalia.com>  2011-11-16 06:47:14 PST ---
(From update of attachment 115371)
View in context: https://bugs.webkit.org/attachment.cgi?id=115371&action=review

Looks good! Maybe consider the following nit :)

> Source/WebKit2/WebProcess/Downloads/soup/DownloadSoup.cpp:69
> +            downloadFailed(downloadDestinationError(response, _("Cannot determine destination URI")));

What about mentioning the value of the suggestedFilename?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.