[Webkit-unassigned] [Bug 72501] New: Improve modulo operation on 32bit platforms

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72501

           Summary: Improve modulo operation on 32bit platforms
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: yuqiang.xian at intel.com
                CC: barraclough at apple.com, fpizlo at apple.com


There's softModulo implementation for ARM in baseline JIT. We can extend it to support more platforms like X86, and also apply it to DFG JIT. As there are some fast paths handling special cases performance gains are expected. On X86 (Core i7 Nehalem) Linux we're able to see 1% improvement on Kraken benchmark, mostly due to the 11% improvement on audio-oscillator. Neutral on SunSpider and V8.

TEST                         COMPARISON            FROM                 TO             DETAILS

=============================================================================

** TOTAL **:                 1.011x as fast    5198.2ms +/- 0.2%   5141.6ms +/- 0.2%     significant

=============================================================================

  ai:                        1.007x as fast     794.1ms +/- 0.4%    788.9ms +/- 0.2%     significant
    astar:                   1.007x as fast     794.1ms +/- 0.4%    788.9ms +/- 0.2%     significant

  audio:                     1.029x as fast    1455.4ms +/- 0.3%   1413.9ms +/- 0.4%     significant
    beat-detection:          ??                 424.1ms +/- 1.0%    425.0ms +/- 0.6%     not conclusive: might be *1.002x as slow*
    dft:                     -                  378.3ms +/- 0.5%    376.8ms +/- 0.4%
    fft:                     -                  255.6ms +/- 0.3%    254.8ms +/- 0.4%
    oscillator:              1.112x as fast     397.4ms +/- 0.3%    357.3ms +/- 0.6%     significant

  imaging:                   -                 2062.5ms +/- 0.3%   2056.4ms +/- 0.3%
    gaussian-blur:           -                  753.6ms +/- 0.2%    752.7ms +/- 0.7%
    darkroom:                -                  417.7ms +/- 0.6%    417.1ms +/- 0.9%
    desaturate:              1.005x as fast     891.2ms +/- 0.5%    886.6ms +/- 0.1%     significant

  json:                      -                  199.4ms +/- 0.7%    199.0ms +/- 0.5%
    parse-financial:         ??                  77.9ms +/- 0.3%     78.1ms +/- 0.3%     not conclusive: might be *1.003x as slow*
    stringify-tinderbox:     -                  121.5ms +/- 1.0%    120.9ms +/- 0.8%

  stanford:                  1.005x as fast     686.8ms +/- 0.5%    683.4ms +/- 0.2%     significant
    crypto-aes:              ??                 137.6ms +/- 0.9%    138.3ms +/- 0.6%     not conclusive: might be *1.005x as slow*
    crypto-ccm:              -                  144.1ms +/- 0.3%    143.3ms +/- 0.7%
    crypto-pbkdf2:           1.010x as fast     294.9ms +/- 0.4%    292.0ms +/- 0.3%     significant
    crypto-sha256-iterative: -                  110.2ms +/- 0.9%    109.8ms +/- 1.2%

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.