[Webkit-unassigned] [Bug 72488] New: Remove unnecessary if check from RenderListBox::paintItemForeground

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72488

           Summary: Remove unnecessary if check from
                    RenderListBox::paintItemForeground
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: xqb748 at motorola.com


There is a if check which checks for visibility before drawing text.

    if (itemStyle->visibility() != HIDDEN)
        paintInfo.context->drawBidiText(itemFont, textRun, r.location());

I think this if check is unnecessary, since there is already an early return available for the visibility and the itemStyle is not modified in between.

The early return is as follows:-
    if (itemStyle->visibility() == HIDDEN)
        return;

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.