[Webkit-unassigned] [Bug 72392] [Qt] [WK2] Crash in Connection::readyReadHandler() on socket error

Wed Nov 16 01:51:36 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=72392

Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #115188|review?                     |review+
               Flag|                            |

--- Comment #2 from Simon Hausmann <hausmann at webkit.org>  2011-11-16 01:51:36 PST ---
(From update of attachment 115188)
I'll say r+ because this fixes a real bug. But I would actually prefer a different solution to the problem:

Instead of working around the fact that SocketNotifierResourceGuard would contain a dangling pointer by changing the scoping, I'd rather see a change that make SocketNotifierResourceGuard robust against this problem, by changing the QSocketNotifier pointer to be a QWeakPointer and checking it in the destructor.

It's easy to introduce these kind of problems, and a more robust guard class makes it harder to do so.

What do you think?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.