[Webkit-unassigned] [Bug 72370] [Gtk] display:none has no effect on <option> element

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72370





--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-11-16 00:16:29 PST ---
(From update of attachment 115319)
View in context: https://bugs.webkit.org/attachment.cgi?id=115319&action=review

> Source/WebCore/platform/gtk/GtkPopupMenu.cpp:72
> -    gtk_widget_show(menuItem);
> +
> +    if (gtk_action_is_visible(action))
> +        gtk_widget_show(menuItem);

Instead of creating a new menu item that will never be shown (because display:none can't change while the popup menu is shown, right?), I think it would be better to simply not create the menu item, In PopupMenuGtk::show() you could do something like:

GRefPtr<GtkAction> action = adoptGRef(createGtkActionForMenuItem(i));
if (gtk_action_is_visible(action.get())
            m_popup->appendItem(action.get());

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.