[Webkit-unassigned] [Bug 70873] [EFL] Invalidation request outside of visible area doesn't seem to occur when tiled view is used.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70873





--- Comment #8 from KwangHyuk <hyuki.kim at samsung.com>  2011-11-16 00:13:51 PST ---
(In reply to comment #7)
> Thanks for your changes. 
> 
> View in context: https://bugs.webkit.org/attachment.cgi?id=115321&action=review
> 
> > Source/WebKit/efl/ewk/ewk_view.cpp:3203
> > + * Function sets if dirty areas should be repainted even if they are out of the screen
> 
> I would rather write: 
>  * Allows to repaint the frame completely even if the areas are out of the screen
>  * when @ewkView is an instance of ewk_view_tiled.
> 
> > Source/WebKit/efl/ewk/ewk_view.cpp:3206
> > + * @param ewkView view object.
> 
> Please do not use dot at the end of parameters' description.
Ok, it looks fine.

> 
> > Source/WebKit/efl/ewk/ewk_view.cpp:3208
> > +void ewk_view_frame_view_creation_notify(const Evas_Object* ewkView)
> 
> In my opinion ewkView shouldn't have const modifier here because ewkView will be changed by ewk_frame_paint_full_set. As you can see this function doesn't have const.
> I should mention about this in my previous review. I am sorry for this.
Looks reasonable.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.