[Webkit-unassigned] [Bug 62857] Chrome not display box-shadow

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62857


David Stone <david at nnucomputerwhiz.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at nnucomputerwhiz.com




--- Comment #5 from David Stone <david at nnucomputerwhiz.com>  2011-11-15 22:34:09 PST ---
Firefox and Opera both use an elements css color for the text-shadow or box-shadow when the color is not specified in the shadow statement. Webkit should be updated to do this as well, using the css color is a more sensible default than transparent and can reduce redundancy in the css file. 

The code change for this is trivial. Change line 3296 of file WebCore/css/CSSStyleSelector.cpp from:

            OwnPtr<ShadowData> shadowData = adoptPtr(new ShadowData(x, y, blur, spread, shadowStyle, id == CSSPropertyWebkitBoxShadow, color.isValid() ? color : Color::transparent));

to:

            OwnPtr<ShadowData> shadowData = adoptPtr(new ShadowData(x, y, blur, spread, shadowStyle, id == CSSPropertyWebkitBoxShadow, color.isValid() ? color : m_style->color()));

I'll prepare an regular patch for this soon.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.