[Webkit-unassigned] [Bug 70407] [TexMap][QT] PageClientQt should skip redundant sync requests during Accelerated Composition.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70407


Noam Rosenthal <noam.rosenthal at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #115315|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #13 from Noam Rosenthal <noam.rosenthal at nokia.com>  2011-11-15 21:54:53 PST ---
(From update of attachment 115315)
View in context: https://bugs.webkit.org/attachment.cgi?id=115315&action=review

Almost there. I allowed myself to help reword the changelog entry, trying to make it more concise and clear.

> Source/WebKit/qt/ChangeLog:12
> +        It relieves the load of calling PageClientQWidget::syncLayers redundantly.
> +        It increases TexMap's performance when PageClientQGraphicsWidget::markForSync is
> +        called many times, especially the time to prepare layers and animations.
> +        The bug is actually that we rely on Timer::startOneShot to do nothing if the
> +        timer is already running, but the Timer fires same times that
> +        Timer::startOneShot was called.

How about "Make sure we only activate the synchronization timer in PageClientQWidget/PageClientQGraphicsWidget if it's not already active, otherwise syncLayers may be called redundantly."

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.