[Webkit-unassigned] [Bug 70873] [EFL] Invalidation request outside of visible area doesn't seem to occur when tiled view is used.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70873





--- Comment #5 from KwangHyuk <hyuki.kim at samsung.com>  2011-11-15 17:43:39 PST ---
(In reply to comment #4)
> View in context: https://bugs.webkit.org/attachment.cgi?id=115129&action=review
> 
> > Source/WebKit/efl/ewk/ewk_view.cpp:3927
> > +#define EWK_VIEW_TILED_TYPE_CHECK_OR_RETURN(ewkView, ...) \
> 
> Can you move this to the define section, please?
> 
OK,

> > Source/WebKit/efl/ewk/ewk_view.cpp:3933
> > +/**
> 
> Please move this function where internal functions are defined.
> 
Ok too.

> > Source/WebKit/efl/ewk/ewk_view.cpp:3935
> > + * Reports it to him that FrameView is created.
> 
> I'd rather write: Reports that FrameView object has been created.
> Please add empty line before detailed descriptions (started with *).
> 
> > Source/WebKit/efl/ewk/ewk_view.cpp:3936
> > + * Paint area is set for full contents rect if view is an instance of ewk_view_tiled
> 
> Please describe it similar to ewk_frame_paint_full_set's doc.
> 
> > Source/WebKit/efl/ewk/ewk_view.cpp:3939
> > + * @param ewkView View.
> 
> I would rather use "view object" instead of View (as we are using it in ewk_view's doc).
> And please do not use dot at the end of params' doc.
> 
> > Source/WebKit/efl/ewk/ewk_view.cpp:3940
> > + *
> 
> Please remove unneeded line.
> 
Ok, I will.

> > Source/WebKit/efl/ewk/ewk_view.cpp:3946
> > +    ewk_frame_paint_full_set(smartData->main_frame, true);
> 
> Do we have a guarantee that for single backing store paintsEntireContents flag is set to false before creating FrameView as you wrote in doc? I am sorry for asking this I am not familiar with backing store. Or should we set it on false in case of single backing store.
> 
Sure, parent of FrameView (ScrollView) set it as false when it created and nobody calls it.
But if TILED_BACKING_STORE is enabled, it can be enabled although ewk_view_single is used.
TILED_BACKING_STORE is not enabled for webkit-efl yet.

> Do we need to call ewk_frame_paint_full_set(smartData->main_frame, true) in _ewk_view_tiled_smart_add() (ewk_view_tiled.cpp) too ?
Good point, let me check it too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.