[Webkit-unassigned] [Bug 72095] [chromium] Font::drawComplexText can not draw a segment of text run

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72095





--- Comment #4 from Robin Cao <robin.cao at torchmobile.com.cn>  2011-11-15 09:50:05 PST ---
Thanks for your comments.

> 
> > Source/WebCore/platform/graphics/chromium/FontLinux.cpp:211
> > +            // No chars in this item to display.
> 
> I think this comment is saying almost the same of above comment. Braces can be removed when this comment is no longer needed.

Good point.

> 
> > Source/WebCore/platform/graphics/chromium/FontLinux.cpp:227
> > +            continue;
> 
> How about having a function which takes |from| and |to| as arguments and handles these logic in ComplexTextController? The function would return false if there is no glyph to be displayed in the run. Otherwise, the function would return true and update values of length() and positions(). This way, we don't need to expose logclusters and beginning offset.

I agree that we should add a function here, but personally, i don't like the idea of updating values of length() and positions() after calling nextScriptRun(). How about adding a function glyphsForRange() which will return the start index and length of glyphs that we need to draw?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.